From 5beaf44407b5311392d180f17e6bc62275a658d2 Mon Sep 17 00:00:00 2001 From: Davide Polonio Date: Mon, 27 Mar 2023 13:19:58 +0200 Subject: [PATCH] chore: add pre-commit checks --- .drone.yml | 7 +- .markdownlint.yaml | 2 + .pre-commit-config.yaml | 31 ++++++++ .run/Execute all tests.run.xml | 2 +- .run/Jooby run.run.xml | 2 +- .run/docker-compose up (debug).run.xml | 2 +- Dockerfile | 2 +- README.md | 18 +++-- conf/application.conf | 2 +- schema/json/ChatContext.json | 2 +- src/etc/stork/stork.yml | 2 +- .../polpetta/mezzotre/InjectionModule.java | 4 +- .../i18n/LocalizedMessageFactory.java | 7 +- .../polpetta/mezzotre/i18n/LocalizedTool.java | 2 +- .../github/polpetta/mezzotre/orm/di/Db.java | 68 +++++++++-------- .../polpetta/mezzotre/orm/model/Base.java | 5 +- .../polpetta/mezzotre/route/Constants.java | 4 +- .../polpetta/mezzotre/route/di/Route.java | 5 +- .../mezzotre/telegram/command/Executor.java | 5 +- .../mezzotre/telegram/command/Start.java | 14 ++-- .../mezzotre/telegram/command/di/Command.java | 37 ++++----- .../polpetta/mezzotre/util/di/ThreadPool.java | 4 +- .../migration/V1_0_0__Create_initial_db.sql | 1 - src/main/resources/i18n/message.properties | 2 +- .../resources/i18n/message_en_US.properties | 2 +- src/main/resources/i18n/message_it.properties | 2 +- .../resources/i18n/message_it_IT.properties | 2 +- src/main/resources/template/command/start.vm | 2 +- .../polpetta/mezzotre/IntegrationTest.java | 7 -- .../helper/IntegrationAppFactory.java | 1 - .../polpetta/mezzotre/helper/Loader.java | 75 +++++++++++-------- .../orm/model/UserIntegrationTest.java | 3 +- .../route/TelegramIntegrationTest.java | 46 ++++++------ .../mezzotre/telegram/command/RouterTest.java | 16 ++-- .../command/StartIntegrationTest.java | 58 +++++++------- .../mezzotre/telegram/command/StartTest.java | 66 ++++++++-------- 36 files changed, 286 insertions(+), 224 deletions(-) create mode 100644 .markdownlint.yaml create mode 100644 .pre-commit-config.yaml diff --git a/.drone.yml b/.drone.yml index 63e3b88..c54ca53 100644 --- a/.drone.yml +++ b/.drone.yml @@ -3,6 +3,11 @@ type: docker name: default steps: + - name: Static checks + image: eclipse-temurin:17-jdk + commands: + - apt-get update -qq && apt-get install python3 pip && pip install pre-commit + - pre-commit run --all-files - name: UT & IT Tests image: quay.io/testcontainers/dind-drone-plugin environment: @@ -41,4 +46,4 @@ services: volumes: - name: dockersock - temp: {} \ No newline at end of file + temp: {} diff --git a/.markdownlint.yaml b/.markdownlint.yaml new file mode 100644 index 0000000..f90ed06 --- /dev/null +++ b/.markdownlint.yaml @@ -0,0 +1,2 @@ +MD013: + line_length: 120 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 0000000..50f5f59 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,31 @@ +# See https://pre-commit.com for more information +# See https://pre-commit.com/hooks.html for more hooks +exclude: "mvnw" +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v4.3.0 + hooks: + - id: trailing-whitespace + - id: end-of-file-fixer + - id: check-yaml + - id: check-added-large-files + - id: check-toml + - id: mixed-line-ending + - repo: https://github.com/gruntwork-io/pre-commit + rev: v0.1.17 + hooks: + - id: shellcheck + - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks + rev: v2.4.0 + hooks: + - id: pretty-format-java + args: [--autofix] + - repo: https://github.com/igorshubovych/markdownlint-cli + rev: v0.32.2 + hooks: + - id: markdownlint + - id: markdownlint-fix + - repo: https://github.com/jorisroovers/gitlint + rev: v0.17.0 + hooks: + - id: gitlint diff --git a/.run/Execute all tests.run.xml b/.run/Execute all tests.run.xml index 28aa703..3a4861c 100644 --- a/.run/Execute all tests.run.xml +++ b/.run/Execute all tests.run.xml @@ -14,4 +14,4 @@